This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_cli): exit with error code while applying fixes #4270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.
|
ematipico
force-pushed
the
fix/check-apply
branch
2 times, most recently
from
af07951
to
3b1161b
Compare
ematipico
force-pushed
the
fix/check-apply
branch
from
673011f
to
304419b
Compare
ematipico
force-pushed
the
fix/check-apply
branch
from
304419b
to
b6a23c9
Compare
ematipico
force-pushed
the
fix/check-apply
branch
from
af964e2
to
b27d280
Compare
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4156
While applying fixes, we track the errors and the fixes. If
errorsexceed 0, we exit with a diagnostic.I also uncovered a bug inside the logic that decides which rules should be applied.
Test Plan
Updated the current tests to reflect the new behaviour
Documentation